Repository navigation
Conversation
Owner
|
saulob
force-pushed
the
feat/main-overlay-ux
branch
from
September 27, 2026 17:26
f133a22 to
2ca4261
Compare
saulob
force-pushed
the
feat/main-overlay-ux
branch
from
September 27, 2026 18:01
2ca4261 to
e80f8cd
Compare
Contributor
Author
Thanks, addressed all three points
I also rebased the branch onto the current master and retested the close behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the first-use experience and general usability of the main Sunrise overlay
It adds
Why
The default overlay key is currently documented in the FAQ
This change brings that information closer to the places where a new user is most likely to need it
The README now provides the basic first-use instruction, while the in-game startup hint makes the configured key immediately discoverable without requiring the user to leave the game
The FAQ remains the detailed reference for changing the key and other configuration information
Main overlay close button
The main overlay now has an X button in the top-right corner
It uses the existing overlay visibility state and closes it directly through the visibility runtime, without simulating the configured keyboard shortcut
The configured keyboard shortcut continues to work normally
This also gives mouse users a visible and familiar way to close the menu
Startup hint
A small startup hint appears shortly after Sunrise initializes
Example
Press INSERT to open the Sunrise overlayThe key is not hardcoded
It uses the actual configured
client.ui.toggle_key, so configurations such asF12,Homeor the other supported keys are reflected automaticallyBehavior
Startup HintoptionHUD positioning
The hint adapts to the currently visible top-left HUD content
If the Sunrise Card is enabled, the hint appears beside it
If the Sunrise Card is disabled, the hint appears beside the first visible HUD overlay instead
If no other HUD overlay is visible, the hint uses the normal top-left HUD position
This keeps the existing vertical HUD stack unchanged and avoids overlapping other HUD elements
README
A short
Opening the overlaysection was added to the READMEIt documents
settings.jsonlocationThe intention is to complement the existing FAQ with a quick first-use reference directly in the repository
Testing
Tested in-game with
settings.jsonScreenshot