Repository navigation
Conversation
throgsoft
marked this pull request as ready for review
September 23, 2026 05:34
throgsoft
marked this pull request as draft
September 23, 2026 19:17
throgsoft
marked this pull request as ready for review
September 24, 2026 02:45
Owner
|
Read installed reward pools, item wrappers, conditions, and Season Pass rows alongside item definitions. Resolve existing server grants through State and publish inventory and acquisition flags in the same transaction. Replace authored engram and material reward tables and Season Pass armor rolls. Share the extracted class-package path, preserve native claim indices, and apply earned progression flags as seasonal experience changes.
…alk owed pass perks
throgsoft
force-pushed
the
runtime-item-definitions
branch
from
September 27, 2026 21:32
089226e to
05ce3ea
Compare
throgsoft
marked this pull request as draft
September 27, 2026 21:36
Contributor
Author
|
cache_investment_records.cpp:136 -> unused slots are 0, which is not in opcode enum and will fail:
consume_deferred tries forever if grant fails, row is not removed:
package_item_rows.cpp:170 -> discards / fails without log:
grant_progress_flags walks every pass row on every XP grant:
kGearsetItemField, kGearsetItemRowClass and kGearsetItemStride have no consumer left and no TODO:
stale refusal reasons on eight failure paths, kDrawCapacity 64 exceeds the grant array and fails:
Bank capacities are all 32768 which is megabytes of excess allocations that may not be required:
Also:
|
…flags, and match rewards to the item catalog
Contributor
Author
|
Also addressed:
|
throgsoft
marked this pull request as ready for review
September 28, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Reward pool contents are now extracted from the installed packages instead of hardcoded. Refactors upstream grant paths (season pass claims) to use the resolver.
season_pass_reward_catalog.h)web_service_record_actions.cpp)Extracted from packages:
Behavior changes:
vendors/tostate/unlocks.Native acquisition order
Inspection of the installed build's native wrapper path confirms that selection and acquisition are interleaved. Each selected item completes acquisition before the next draw evaluates its conditions. An automatic child wrapper opens before its own acquisition flag is set, so later parent draws can observe flags acquired by earlier children. This is the ordering contract for wrapper resolution; acquisition flags must not make an otherwise empty top-level draw eligible.
Validation
On a fresh database install, I used db key
character_slot = -1, bank = 6, slot = 38, lane = 0, value = <desired XP>in theunlockstable to set xp. Tested all season pass reward claims in-game.NOTE 1: Failed claims will log
instance_capacityif the target buckets are full. The fix is to implement overflow routing and the FIFO eviction policy for the postmaster bucket which remains as separate follow-up work.NOTE 2: I found no package data establishing which rewards the rabbit or cat statues grant.
dreambane_engramis a candidate for rabbit rewards but I could not verify that association nativelyNOTE 3: Reward-roll seeds remain ephemeral. Durable seed storage is deferred with overflow/FIFO work. The inherited season-pass issue where claiming the planetary materials package can make other policy rewards appear full is also outside this PR; no speculative ring-buffer or refresh workaround is included.