Skip to content

[DNM] Segment arena relocation fix upstream - #2048

Closed
gabrielbosio wants to merge 2 commits into
mainfrom
segment-arena-relocation-fix-upstream
Closed

[DNM] Segment arena relocation fix upstream#2048
gabrielbosio wants to merge 2 commits into
mainfrom
segment-arena-relocation-fix-upstream

Conversation

@gabrielbosio

Copy link
Copy Markdown
Contributor

Clone of #1845

@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown
**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.187 s ±  0.043 s    [User: 25.427 s, System: 0.759 s]
  Range (min … max):   26.156 s … 26.217 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.409 s ±  0.005 s    [User: 25.643 s, System: 0.762 s]
  Range (min … max):   26.405 s … 26.412 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.582 s ±  0.086 s    [User: 25.570 s, System: 0.797 s]
  Range (min … max):   14.521 s … 14.642 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.646 s ±  0.050 s    [User: 25.693 s, System: 0.817 s]
  Range (min … max):   14.611 s … 14.681 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.538 s ±  0.632 s    [User: 38.024 s, System: 0.946 s]
  Range (min … max):   10.091 s … 10.985 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.573 s ±  0.386 s    [User: 37.400 s, System: 0.955 s]
  Range (min … max):   10.300 s … 10.846 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.00 ± 0.07 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.305 s ±  0.204 s    [User: 38.298 s, System: 0.996 s]
  Range (min … max):   10.161 s … 10.450 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.472 s ±  0.041 s    [User: 37.777 s, System: 0.996 s]
  Range (min … max):   10.443 s … 10.501 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.544 s ±  0.287 s    [User: 38.327 s, System: 0.989 s]
  Range (min … max):   10.341 s … 10.747 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.494 s ±  0.148 s    [User: 38.262 s, System: 1.019 s]
  Range (min … max):   10.389 s … 10.599 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.00 ± 0.03 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.275 s ±  0.024 s    [User: 38.719 s, System: 1.083 s]
  Range (min … max):   10.257 s … 10.292 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.411 s ±  0.287 s    [User: 38.700 s, System: 1.098 s]
  Range (min … max):   10.208 s … 10.613 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.03 times faster than hyper_threading_pr threads: 16


@github-actions

github-actions Bot commented Apr 4, 2025

Copy link
Copy Markdown

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.186 ± 0.027 2.157 2.258 1.01 ± 0.01
head big_factorial 2.154 ± 0.009 2.140 2.169 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.062 ± 0.016 2.040 2.098 1.00
head big_fibonacci 2.067 ± 0.025 2.038 2.097 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.795 ± 0.150 7.598 8.053 1.00
head blake2s_integration_benchmark 7.796 ± 0.137 7.626 8.108 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.356 ± 0.038 2.323 2.435 1.03 ± 0.02
head compare_arrays_200000 2.287 ± 0.026 2.249 2.328 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.515 ± 0.027 1.473 1.551 1.00
head dict_integration_benchmark 1.521 ± 0.014 1.501 1.540 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.269 ± 0.013 1.250 1.291 1.00
head field_arithmetic_get_square_benchmark 1.273 ± 0.023 1.247 1.325 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.859 ± 0.134 7.686 8.106 1.00 ± 0.03
head integration_builtins 7.841 ± 0.229 7.662 8.312 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.978 ± 0.095 7.834 8.155 1.01 ± 0.01
head keccak_integration_benchmark 7.916 ± 0.045 7.852 7.986 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.179 ± 0.014 2.160 2.210 1.00
head linear_search 2.270 ± 0.031 2.215 2.306 1.04 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.621 ± 0.015 1.608 1.655 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.607 ± 0.022 1.575 1.642 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.539 ± 0.018 1.515 1.566 1.01 ± 0.01
head math_integration_benchmark 1.523 ± 0.012 1.505 1.542 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.266 ± 0.014 1.251 1.294 1.00
head memory_integration_benchmark 1.282 ± 0.007 1.267 1.293 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.647 ± 0.023 1.610 1.678 1.00 ± 0.02
head operations_with_data_structures_benchmarks 1.643 ± 0.019 1.620 1.677 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 548.4 ± 3.1 544.3 552.6 1.00
head pedersen 551.4 ± 8.3 543.9 573.1 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 676.9 ± 6.3 668.7 686.6 1.03 ± 0.02
head poseidon_integration_benchmark 655.9 ± 8.2 640.0 665.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.925 ± 0.024 1.891 1.977 1.02 ± 0.02
head secp_integration_benchmark 1.897 ± 0.017 1.877 1.931 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 675.0 ± 4.6 668.5 681.3 1.01 ± 0.01
head set_integration_benchmark 670.9 ± 5.5 662.5 679.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.341 ± 0.047 4.265 4.451 1.00 ± 0.01
head uint256_integration_benchmark 4.322 ± 0.032 4.266 4.355 1.00

@codecov

codecov Bot commented Apr 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (368e3fb) to head (685fc69).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2048   +/-   ##
=======================================
  Coverage   96.54%   96.55%           
=======================================
  Files         102      102           
  Lines       42791    42872   +81     
=======================================
+ Hits        41312    41394   +82     
+ Misses       1479     1478    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrancoGiachetta

Copy link
Copy Markdown
Contributor

The original PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants