Skip to content

perf(array): always double capacity on realloc - #1659

Merged
TomerStarkware merged 1 commit into
mainfrom
array-growth-always-double
Aug 30, 2026
Merged

perf(array): always double capacity on realloc#1659
TomerStarkware merged 1 commit into
mainfrom
array-growth-always-double

Conversation

@TomerStarkware

@TomerStarkware TomerStarkware commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

Previously growth was capped at +1024 elements once capacity reached 512,
making large arrays grow linearly (O(n^2) total copying). Now capacity
always doubles (minimum 8).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@TomerStarkware
TomerStarkware requested a review from orizi August 26, 2026 13:32
@github-actions

Copy link
Copy Markdown

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.472 ± 0.041 10.398 10.530 5.72 ± 0.06
cairo-native (embedded AOT) 1.830 ± 0.017 1.804 1.865 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 1.838 ± 0.012 1.818 1.856 1.00 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 528.1 ± 4.5 521.7 536.1 1.00
cairo-native (embedded AOT) 1634.2 ± 8.7 1621.1 1649.5 3.09 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 1657.8 ± 9.2 1648.8 1678.8 3.14 ± 0.03

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.656 ± 0.018 4.635 4.686 2.75 ± 0.03
cairo-native (embedded AOT) 1.693 ± 0.014 1.672 1.723 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 1.734 ± 0.019 1.709 1.762 1.02 ± 0.01

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.570 ± 0.028 4.535 4.618 2.79 ± 0.04
cairo-native (embedded AOT) 1.635 ± 0.019 1.618 1.669 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 1.665 ± 0.020 1.630 1.696 1.02 ± 0.02

Benchmark for program linear_search

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 571.0 ± 10.2 558.4 593.8 1.00
cairo-native (embedded AOT) 1658.2 ± 17.9 1638.4 1686.1 2.90 ± 0.06
cairo-native (embedded JIT using LLVM's ORC Engine) 1685.9 ± 12.9 1671.7 1707.7 2.95 ± 0.06

Benchmark for program logistic_map

Open benchmarks
Command Mean [ms] Min [ms] Max [ms] Relative
Cairo-vm (Rust, Cairo 1) 483.7 ± 5.0 476.7 492.1 1.00
cairo-native (embedded AOT) 1637.1 ± 9.5 1620.9 1649.3 3.38 ± 0.04
cairo-native (embedded JIT using LLVM's ORC Engine) 1665.3 ± 14.1 1645.6 1692.5 3.44 ± 0.05

@github-actions

Copy link
Copy Markdown

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 1.940 ± 0.020 1.913 1.972 1.00 ± 0.02
base dict_insert.cairo (AOT) 1.932 ± 0.022 1.911 1.986 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 1.878 ± 0.033 1.840 1.949 1.00
head dict_insert.cairo (AOT) 1.880 ± 0.036 1.842 1.945 1.00 ± 0.03

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 1.742 ± 0.012 1.719 1.760 1.00 ± 0.02
base dict_snapshot.cairo (AOT) 1.740 ± 0.034 1.694 1.803 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 1.687 ± 0.018 1.669 1.722 1.03 ± 0.01
head dict_snapshot.cairo (AOT) 1.637 ± 0.014 1.616 1.663 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 1.833 ± 0.023 1.782 1.856 1.02 ± 0.02
base factorial_2M.cairo (AOT) 1.798 ± 0.015 1.773 1.819 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 1.759 ± 0.026 1.724 1.798 1.01 ± 0.02
head factorial_2M.cairo (AOT) 1.742 ± 0.027 1.700 1.778 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 1.740 ± 0.018 1.713 1.769 1.00
base fib_2M.cairo (AOT) 1.748 ± 0.019 1.718 1.776 1.00 ± 0.02

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 1.706 ± 0.015 1.682 1.726 1.01 ± 0.01
head fib_2M.cairo (AOT) 1.689 ± 0.011 1.677 1.711 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 1.812 ± 0.046 1.760 1.909 1.02 ± 0.04
base linear_search.cairo (AOT) 1.772 ± 0.043 1.724 1.848 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 1.711 ± 0.027 1.671 1.766 1.01 ± 0.02
head linear_search.cairo (AOT) 1.690 ± 0.017 1.655 1.710 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 1.771 ± 0.017 1.741 1.798 1.02 ± 0.02
base logistic_map.cairo (AOT) 1.728 ± 0.032 1.685 1.791 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 1.742 ± 0.035 1.690 1.789 1.01 ± 0.03
head logistic_map.cairo (AOT) 1.733 ± 0.026 1.694 1.773 1.00

@orizi orizi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on TomerStarkware).

@TomerStarkware
TomerStarkware added this pull request to the merge queue Aug 30, 2026
Merged via the queue into main with commit b3bc979 Aug 30, 2026
15 checks passed
@TomerStarkware
TomerStarkware deleted the array-growth-always-double branch August 30, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants