Skip to content

Upload leaf_prover and recursive_tree arch binaries #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YairVaknin-starkware wants to merge 2 commits into from
Closed

Upload leaf_prover and recursive_tree arch binaries #410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3cc389
Upload leaf_prover and recursive_tree arch binaries
YairVaknin-starkware Jul 23, 2026
ef420cc
test
YairVaknin-starkware Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 83 additions & 1 deletion .github/workflows/upload_artifacts_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Upload-Artifacts
on:
push:
branches:
- main
- yairv/add_new_bins_to_ul_workflows

@cursor cursor Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload workflow missing main trigger

High Severity

The push trigger lists only yairv/add_new_bins_to_ul_workflows and no longer includes main. After merge, pushes to main will not run Upload-Artifacts, so release binaries (including the new leaf_prover and arch stwo_run_and_prove_recursive_tree uploads) would stop being published from the default branch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ef420cc. Configure here.


jobs:
artifacts-push:
Expand Down Expand Up @@ -53,6 +53,16 @@ jobs:
path: "target/release/stwo_run_and_prove"
destination: "sharp-binary-artifacts/stwo_run_and_prove_artifacts/${{ env.SHORT_HASH }}/release"

- name: Rename leaf-prover binary
run: mv target/release/leaf-prover target/release/leaf_prover

- name: Upload leaf_prover x86_64 binary to GCP
id: upload_leaf_prover
uses: "google-github-actions/upload-cloud-storage@v2"
with:
path: "target/release/leaf_prover"
destination: "sharp-binary-artifacts/leaf_prover_artifacts/${{ env.SHORT_HASH }}/release"

- name: Upload stwo_run_and_prove_recursive_tree binary to GCP
id: upload_stwo_run_and_prove_recursive_tree
uses: "google-github-actions/upload-cloud-storage@v2"
Expand Down Expand Up @@ -95,3 +105,75 @@ jobs:
with:
arch: graniterapids
binary_name: stwo-run-and-prove

- name: Build and upload leaf_prover for znver5
uses: ./.github/actions/build-arch-binary
with:
arch: znver5
binary_name: leaf-prover

- name: Build and upload leaf_prover for znver4
uses: ./.github/actions/build-arch-binary
with:
arch: znver4
binary_name: leaf-prover

- name: Build and upload leaf_prover for znver3
uses: ./.github/actions/build-arch-binary
with:
arch: znver3
binary_name: leaf-prover

- name: Build and upload leaf_prover for emeraldrapids
uses: ./.github/actions/build-arch-binary
with:
arch: emeraldrapids
binary_name: leaf-prover

- name: Build and upload leaf_prover for sapphirerapids
uses: ./.github/actions/build-arch-binary
with:
arch: sapphirerapids
binary_name: leaf-prover

- name: Build and upload leaf_prover for graniterapids
uses: ./.github/actions/build-arch-binary
with:
arch: graniterapids
binary_name: leaf-prover

- name: Build and upload stwo_run_and_prove_recursive_tree for znver5
uses: ./.github/actions/build-arch-binary
with:
arch: znver5
binary_name: stwo_run_and_prove_recursive_tree

- name: Build and upload stwo_run_and_prove_recursive_tree for znver4
uses: ./.github/actions/build-arch-binary
with:
arch: znver4
binary_name: stwo_run_and_prove_recursive_tree

- name: Build and upload stwo_run_and_prove_recursive_tree for znver3
uses: ./.github/actions/build-arch-binary
with:
arch: znver3
binary_name: stwo_run_and_prove_recursive_tree

- name: Build and upload stwo_run_and_prove_recursive_tree for emeraldrapids
uses: ./.github/actions/build-arch-binary
with:
arch: emeraldrapids
binary_name: stwo_run_and_prove_recursive_tree

- name: Build and upload stwo_run_and_prove_recursive_tree for sapphirerapids
uses: ./.github/actions/build-arch-binary
with:
arch: sapphirerapids
binary_name: stwo_run_and_prove_recursive_tree

- name: Build and upload stwo_run_and_prove_recursive_tree for graniterapids
uses: ./.github/actions/build-arch-binary
with:
arch: graniterapids
binary_name: stwo_run_and_prove_recursive_tree
Loading