starknet_api: make contract address derivation hash-pluggable - #14811
Draft
ron-starkware wants to merge 1 commit into
Draft
starknet_api: make contract address derivation hash-pluggable#14811ron-starkware wants to merge 1 commit into
ron-starkware wants to merge 1 commit into
Conversation
|
This change is |
Contributor
Author
This was referenced Jul 15, 2026
|
Artifacts upload workflows: |
ron-starkware
force-pushed
the
ron/contract-address/pluggable-hash
branch
from
July 19, 2026 09:19
bc96b38 to
85b0748
Compare
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
Introduce AddressDerivationHash {Pedersen, Blake2} and parameterize
calculate_contract_address over it via a generic inner helper. The scheme is
selected per transaction version at the derivation sites -- there is no
network-wide cutover and no runtime flag. Every caller still passes Pedersen,
so this is a behavior-preserving refactor that prepares DeployAccount v4.
The deploy / deploy-account transaction-hash functions now take the already-
derived ContractAddress as a parameter instead of recomputing it, which leaves
the broad TransactionHasher trait unchanged and keeps the scheme choice at the
derivation sites.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ron-starkware
force-pushed
the
ron/contract-address/pluggable-hash
branch
from
August 31, 2026 12:56
85b0748 to
dcefda7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack — part 1 of 9 (
ron/contract-address/*, one commit per branch). Targets 0.14.5.Introduces
AddressDerivationHash { Pedersen, Blake2 }and parameterizescalculate_contract_addressover it through a generic inner helper.The scheme is selected per transaction version at the derivation sites — there is no network-wide cutover, no protocol-version gate and no runtime flag. Every caller in this PR still passes
Pedersen, so this is a behavior-preserving refactor that preparesDeployAccountv4 (#14813) and thedeploy_v2syscall (#14817).The deploy / deploy-account transaction-hash functions now take the already-derived
ContractAddressas a parameter instead of recomputing it. That leaves the broadTransactionHashertrait unchanged and keeps the scheme choice at the derivation sites, where the per-version dispatch lands.🤖 Generated with Claude Code