Conversation
- Adjust indentation and spacing for clarity - Remove redundant variables and simplify logic in detectFormat functions - Standardize Logger error class and function names
- Verify correct parser routing by checking for parser-specific error messages - Validate unknown format rejection with appropriate error messages
- Use ImageParserTest consistently - Convert tests to use TEST_F with shared fixtures - Reduce code duplication across image/mesh parser tests - Fix mesh error msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor tests to eliminate code duplication and standardize test patterns better. Includes consistency improvements and error logging label fixes.
Changes
ImageParserTestmore consistently where applicablecreateTestFile()more consistently and remove duplicate createTestFile functions