Support pulling a private image; dogfood the action in CI#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published image is private (the organization disallows public packages), so an unauthenticated pull 403s. Rather than block on that policy, make both wrappers able to pull a private image.
GITHUB_TOKEN, which is enough for an image in the same organization (permissions: packages: read); passregistry-tokenfor anything else, or leave it empty for a public image.DOCKER_AUTH_CONFIG(group-level variable holding a base64user:PATwithread:packages) — GitLab hands it to the runner automatically.url/secretare now optional somode: offruns (scan-only, no upload) work without them.Once the org allows public packages the login is a no-op for consumers who drop the token.