Add "Disabled" option to JSON-LD entity type#604
Merged
Conversation
Allows users to disable the built-in Organization/Person schema generation while still using the Custom Schema textarea for full control over their JSON-LD markup. Fixes #593 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thanks @duncanmcclean, I noticed this bug yesterday. It's like you can read my thoughts. Much appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a "Disabled" option to the JSON-LD entity type selector in Site Defaults.
Previously, the entity type only offered "Organization" or "Person" options. Developers wanting full control over their JSON-LD schema had to leave the organization name blank to prevent the built-in schema from rendering — but this was fragile, as editors could fill it in later, causing duplicate schemas.
This PR adds a third "Disabled" option that explicitly opts out of the built-in entity schema while still allowing the Custom Schema textarea to be used for complete control over the JSON-LD markup.
We may look to add a more complicated "schema builder" in the future, but for now, we want to keep things simple + flexible so this is the easiest solution.
Closes #593