Handle trailing slashes when matching redirects#610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a redirect rule for
/foowould not be triggered when visiting the same URL with a trailing slash (/foo/).This was happening because
HandleRedirectslooked up the incoming request path against stored redirect sources verbatim, so a request to/foo/(which keeps its trailing slash) never matched a rule stored as/foo.This PR fixes it by matching the request path against both its trailing-slash and non-trailing-slash variants, so visiting
/foo/finds a/foorule and vice-versa. The root path (/) is left untouched.Fixes #609