Fix invalid breadcrumb JSON-LD schema on taxonomy pages#611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the BreadcrumbList JSON-LD schema rendered an invalid
itemListElementon taxonomy term pages — an object with non-sequential numeric keys and gaps (e.g.{"0":{...position 1...},"2":{...position 3...}}) instead of a sequential array.This was happening because the
nav:breadcrumbstag drops any taxonomy crumb whose template doesn't exist, and Laravel'sreject()preserves the collection's keys. When SEO Pro then mapped over the breadcrumbs, it used the collection key as theposition, so the leftover gapped keys produced non-sequential positions and->all()serialised the result as a JSON object rather than an array. Regular entries weren't affected because every URL segment resolves to a viewable page, so nothing gets dropped.This PR fixes it by calling
->values()on the breadcrumbs before mapping, re-indexing the collection so positions are contiguous (1..n) and the output is always a sequential JSON array.Fixes #608