Scope duplicate title & description checks to the current site#615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where SEO Pro would flag duplicate titles and descriptions across sites in a multi-site.
This was happening because the
UniqueTitleTagandUniqueMetaDescriptionrules compared each page's title/description against every page in the report, regardless of which site it belonged to.Since localized entries inherit their origin's title and description, the same content served on different sites (e.g.
/and/ga/) collided and was reported as duplicate. This is a false positive, as these are hreflang alternates that Google treats as the same page rather than duplicates.This PR fixes it by scoping the uniqueness comparison to pages on the same site.
Fixes #213