Skip to content

Make properly pip installable without needing build isolation (uv pip install now works too)#402

Merged
tridao merged 3 commits into
state-spaces:mainfrom
kszlim:main
Aug 6, 2024
Merged

Make properly pip installable without needing build isolation (uv pip install now works too)#402
tridao merged 3 commits into
state-spaces:mainfrom
kszlim:main

Conversation

@kszlim
Copy link
Copy Markdown
Contributor

@kszlim kszlim commented Jun 18, 2024

Now you can just pip install mamba_ssm and it will work, previously it would throw unless you had packaging and torch already installed. It would also always fail if you had build isolation on (which will be on by default in the future within pip).

As a side effect, now uv can uv pip install mamba_ssm properly now.

Take note that installing causal-conv1d via the optional extra will still fail with build isolation due to that package needing similar changes to this one.

@kszlim
Copy link
Copy Markdown
Contributor Author

kszlim commented Jun 18, 2024

I tested this by creating an empty workspace/venv where i pip installed mamba_ssm into with uv and pip with build isolation on.

I also verified that I could run the benchmark.

Please give this a spin and see if it works for you.

@kszlim
Copy link
Copy Markdown
Contributor Author

kszlim commented Jun 18, 2024

If Dao-AILab/causal-conv1d#26 is merged, then:

Take note that installing causal-conv1d via the optional extra will still fail with build isolation due to that package needing similar changes to this one.

Should no longer be true.

@kszlim
Copy link
Copy Markdown
Contributor Author

kszlim commented Jul 22, 2024

@albertfgu @tridao any chance this can be accepted (i'll update it if so), otherwise this can be closed.

@riZZZhik
Copy link
Copy Markdown

riZZZhik commented Aug 5, 2024

@albertfgu @tridao Hi,

Can you approve this pr?
It actually fixes installation issues with this library

btw @kszlim thanks, good work!

@kdre
Copy link
Copy Markdown

kdre commented Aug 6, 2024

Please approve this pr. It also fixed my installation issue.

@tridao tridao merged commit 323db26 into state-spaces:main Aug 6, 2024
@amrit110
Copy link
Copy Markdown

Hi @tridao when is a new release to pypi expected with this fix? The installation of the latest available package fails.

Esthercyz pushed a commit to Esthercyz/mamba_1 that referenced this pull request Jan 29, 2026
… install now works too) (state-spaces#402)

Co-authored-by: Tri Dao <tridao@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants