fix: Add MSVC support for Windows#846
Open
LAWArthur wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a patch to make it ready to use on Windows, while keeping everything intact on other platforms.
What's Changed
pyproject.toml: Add platform-specific triton dependencies, because the triton doesn't provide Windows wheels, howevertriton-windowsis available.selective_scan_fwd_kernel.cuhandselective_scan_bwd_kernel.cuh:M_LOG2Econstant if not providedstatic_switch.h: changed tostatic constexprdue to MSVC-specific constraints for template params.Why It's Important
Current code meets a great lot issues when compiling using MSVC on Windows (which is forced by PyTorch) due to specific language features unsupported by MSVC, which makes it a hard time to debug and fix for many.