Repository navigation
Link against zstd, which current ProteoWizard needs - #36
Open
percolator wants to merge 1 commit into
Open
percolator wants to merge 1 commit into
percolator wants to merge 1 commit into
Conversation
A build against a ProteoWizard fetched today fails at the link step with undefined references to ZSTD_compress, ZSTD_getErrorCode, ZSTD_defaultCLevel and others, from libpwiz_data_msdata_core.a: ProteoWizard now compresses binary data with zstd. Two things are missing. install_proteowizard.sh creates plain-name symlinks for the Boost components only, so bjam's libzstd-gcc11-mt-s.a is invisible to -lzstd; and FindProteoWizard.cmake never asks for the library, so it is not on the link line at all. The find is optional, since ProteoWizard releases predating the zstd compression do not build it, and it appends after the libraries that reference it, which is what a single-pass linker needs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D7vADr6Z93sRBvfNGHUwW6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
A build against a ProteoWizard fetched today fails at the link step:
ProteoWizard compresses binary data with zstd now, so
pwiz_data_msdata_corereferences it. Two things are missing on our side:admin/builders/install_proteowizard.shcreates plain-name symlinks for the Boost components only (its line 77). bjam names its outputlibzstd-gcc11-mt-s.a, so-lzstdfinds nothing.cmake/FindProteoWizard.cmakenever asks for the library, so it is not on the link line at all.The fix
A symlink for zstd alongside the Boost ones, and an optional
find_libraryin the find module. Optional because ProteoWizard releases predating the zstd compression do not build it; the message says so when it is absent. It is appended after the libraries that reference it, which is what a single-pass linker needs.Testing
Ubuntu 22.04, gcc 11, ProteoWizard 3.0.26260 built by
admin/builders/install_proteowizard.shfrom this branch.masterdoes not link at all on that toolchain; with this change it builds andmaracluster unit-testpasses.Found while preparing #35, but independent of it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D7vADr6Z93sRBvfNGHUwW6