test: remove stdout and std from test by mocking logger module#143
Closed
marcalexiei wants to merge 3 commits intostats-organization:npm-packagefrom
Closed
test: remove stdout and std from test by mocking logger module#143marcalexiei wants to merge 3 commits intostats-organization:npm-packagefrom
marcalexiei wants to merge 3 commits intostats-organization:npm-packagefrom
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
marcalexiei
changed the title
Member
|
GitHub auto-closed this PR because the target branch doesn't exist anymore. Anyway I'll review it next. |
martin-mfg
reviewed
Apr 18, 2026
| }); | ||
|
|
||
| afterEach(() => { | ||
| logSpy.mockClear(); |
Member
There was a problem hiding this comment.
Currently logSpy is only cleared, but there are no expect calls for it yet.
Apart from this everything looks good to me. Thanks for your nice work, as always! :)
martin-mfg
pushed a commit
that referenced
this pull request
Apr 19, 2026
- Same as #143 - Resolves #143 (comment) - Closes #141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.