feat: add reference for IpCidr and IpNet#20
Closed
Sherlock-Holo wants to merge 1 commit into
Closed
Conversation
Currently IpCidr and IpNet will return the first_address/address directly, it's ok, but when if we want to use IpCidr as radix trie key, many radix trie implement require the key type can borrowed as &[u8], however we can't return a the local variable(the IpAddr) reference. With this PR we can borrow the IpAddr in IpCidr/IpNet directly to avoid this problem
Owner
|
Sounds reasonable; I don't think the underlying storage is going to change, to adding this API should be future-proof. Merged in c9f557b Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently IpCidr and IpNet will return the first_address/address directly, it's ok, but when if we want to use IpCidr as radix trie key, many radix trie implement require the key type can borrowed as &[u8], however we can't return a the local variable(the IpAddr) reference. With this PR we can borrow the IpAddr in IpCidr/IpNet directly to avoid this problem