add jsonschema feature to derive JsonSchema#22
Conversation
c96f21f to
6b223fc
Compare
Signed-off-by: Daniel Maslowski <info@orangecms.org>
6b223fc to
a16db49
Compare
|
Please don't submit AI/LLM/... generated code. Can't say for sure whether this is what happened here, but I'm quite sure this is broken - because manual If you're serious about this please add test cases producing both JSON values and schemas (as JSON text is probably fine); I really hope that the JSON values are simple strings, because they should take the Also: is there a good reason not to name the feature the same as the dependency? Is there any upstream guidance about that? |
|
Let me first assure you that I'm not using any LLM crap. I just quickly added the derives here, will check regarding their actual outputs and adding test cases, and whether manual implementations are necessary. Regarding the naming: Yea I get your point, I haven't seen recommendations on this yet, will also check. I was thinking that naming after the functionality, in this case the trait, made sense. We can find an agreement here as you like, I don't have a strong opinion on it. 🙂 Thank you for your feedback! |
see #21