fix: use secrets module instead of random for secure password generation#1298
Closed
Ashvin-KS wants to merge 1 commit into
Closed
fix: use secrets module instead of random for secure password generation#1298Ashvin-KS wants to merge 1 commit into
Ashvin-KS wants to merge 1 commit into
Conversation
Replaces random.randint and random.choice with secrets.randbelow and secrets.choice to generate cryptographically secure random values. Closes steam-bell-92#1294
|
@Ashvin-KS is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
andom.randint and
andom.choice with secrets.randbelow and secrets.choice to generate cryptographically secure random values.
Changes
andom.randint(0, 9) with secrets.randbelow(10)
andom.randint(12, 24) with secrets.randbelow(13) + 12
andom.choice(...) with secrets.choice(...)
Why
The
andom module uses the Mersenne Twister PRNG, which produces predictable sequences. For password generation, we need cryptographically secure randomness provided by the secrets module.
Closes #1294