[BUG] Password generator uses weak random module instead of secrets module#1332
Open
Siddh2024 wants to merge 1 commit into
Open
[BUG] Password generator uses weak random module instead of secrets module#1332Siddh2024 wants to merge 1 commit into
Siddh2024 wants to merge 1 commit into
Conversation
- Switch from random.randint to secrets.randbelow - Switch from random.choice to secrets.choice - Ensures cryptographically secure password generation Fixes steam-bell-92#1294
|
@Siddh2024 is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1294 by replacing the insecure
andom\ module with the cryptographically secure \secrets\ module in the Password Forge game.
Changes Made
andom.randint(0, 9)\ with \secrets.randbelow(10)\ for banned digit generation
andom.randint(12, 24)\ with \secrets.randbelow(13) + 12\ for target sum generation
andom.choice(...)\ with \secrets.choice(...)\ for lucky letter selection
The \secrets\ module uses cryptographically strong randomness (OS-provided entropy), making generated values unpredictable — essential for any password-related functionality.
Related Issue
Fixes #1294