Fix session conflicts: clear stale cache and detect login redirects (#323)#324
Open
JosephDoUrden wants to merge 3 commits intosteipete:mainfrom
Open
Fix session conflicts: clear stale cache and detect login redirects (#323)#324JosephDoUrden wants to merge 3 commits intosteipete:mainfrom
JosephDoUrden wants to merge 3 commits intosteipete:mainfrom
Conversation
- Factory: clear FactorySessionStore when cached cookies fail auth (401/403), preventing stale account data after account switches - Amp: detect login page redirects in RedirectDiagnostics and abort early, avoiding infinite redirect loops on invalid sessions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d71296f7b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Factory: clear FactorySessionStore alongside CookieHeaderCache when cached cookies fail authentication, preventing stale account data after account switches - Amp: detect login-page redirects and abort early to avoid redirect loops - Amp: return invalidCredentials on login redirect instead of generic HTTP 302 errors for clearer UX
ratulsarna
added a commit
that referenced
this pull request
Feb 9, 2026
Extracted from #324 (thanks @JosephDoUrden).
ratulsarna
added a commit
that referenced
this pull request
Feb 9, 2026
Extracted from #324 (thanks @JosephDoUrden).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes session-related edge cases that caused stale account data and redirect loops.
FactorySessionStorewhen cached cookie headers fail authentication (401/403), ensuring account changes are reflected correctly.RedirectDiagnosticsand aborts early, preventing infinite redirect loops when sessions are invalid.Root cause
Cached session data was not cleared when authentication failed, allowing stale account state to persist.
Additionally, Amp login redirects were not recognized as terminal failures, leading to repeated redirects.
Test plan
Fixes #323