Add color-coded menu bar icons and separator style option#356
Add color-coded menu bar icons and separator style option#356johnlarkin1 wants to merge 1 commit intosteipete:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d5594b9e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _ = self.kimiCookieSource | ||
| _ = self.augmentCookieSource | ||
| _ = self.ampCookieSource | ||
| _ = self.colorCodedIcons |
There was a problem hiding this comment.
StatusItemController only refreshes the menu bar when settings.menuObservationToken changes, but this token never reads menuBarSeparatorStyle even though rendering now depends on it (StatusItemController+Animation.swift calls self.settings.menuBarSeparatorStyle in menuBarDisplayText). As a result, changing the Separator picker can leave the menu bar text unchanged until some unrelated setting/store update happens, making the new preference appear broken.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I agree with CC... this appears to be a false positive of a comment...
The very next line references self.menuBarSeparatorStyle.
johnlarkin1
force-pushed
the
upstream-pr/color-menu-bar-gradient
branch
from
0d5594b to
1507031
Compare
|
The |
Add UsageColorLevel to tint menu-bar icons green/yellow/red based on remaining quota, plus a configurable separator style (dot, dash, pipe, slash, colon) between provider and usage text. New files: - UsageColorLevel.swift – threshold logic + NSColor mapping - MenuBarSeparatorStyle.swift – separator enum + picker - Public/bar-usage-pace.png, separator-option.png – docs images Modified: - StatusItemController+Animation – apply color tint to icon - MenuBarDisplayText – use separator setting - PreferencesDisplayPane / PreferencesAdvancedPane – new UI controls - SettingsStore* – persist new preferences
johnlarkin1
force-pushed
the
upstream-pr/color-menu-bar-gradient
branch
from
1507031 to
cb9f02b
Compare
1 participant
Summary
New files
UsageColorLevel.swiftMenuBarSeparatorStyle.swiftPublic/bar-usage-pace.pngPublic/separator-option.pngModified files
StatusItemController+Animation.swiftMenuBarDisplayText.swiftPreferencesDisplayPane.swiftPreferencesAdvancedPane.swiftSettingsStore*.swift(4 files)Notes
This PR is independent but pairs well with #353 (credential simplification), #354 (weekly projection), and #355 (hourly pace). No code dependencies between them.
Test plan
swift build)🤖 Generated with Claude Code