Circuit-breaker events + audit-log pagination - #342
Merged
Idaonoli merged 3 commits intoSep 3, 2026
Conversation
|
@luhrhenz is attempting to deploy a commit to the idaonoli-2655's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@deeejaymu-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frozen/Unfrozencontract events fromcircuit-breaker'sfreeze/unfreeze, following the repo's shared event conventions (admin address as topic), with EVENTS.md and indexer decoder updates.list_entries(env, start, limit) -> Vec<LogEntry>view toaudit-log, with a dedicatedPageTooLargeerror whenlimitexceedsMAX_PAGE_SIZE, plus unit tests covering multi-page pagination and the overflow error.Notes
contracts/allowlist-token/src/lib.rsandcontracts/denylist-gate/src/lib.rscurrently have pre-existing issues unrelated to audit-log (duplicate function definitions, undefined symbols such asMetadata,PendingAdmin,caller,Paused/Unpaused/GatePausedevents,ComplianceOfficer/BatchTooLarge/SignerSet, and missing imports). Wiring in audit-log calls on top of that would not produce reviewable or verifiable changes; commented on both issues explaining this, and this PR closes them as no further action is possible until the base files are repaired in a follow-up.Closes #210
Closes #207
Closes #208
Closes #209