feat: add dry-run slashing, logger cleanup, and token registry persis… - #350
Open
jiyiola396-pixel wants to merge 1 commit into
Open
Conversation
|
@jiyiola396-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers the core on-chain enforcement and observability work needed for the current rollout:
What changed
Solver slashing
SolverRegistryService.slashSolver()now simulates, then submits theslashtransaction when the dry-run flag is off.SlashResultresponses instead of bubbling as exceptions.Logging cleanup
console.*calls with the shared Winston logger in the Soroban event-ingestion and sweeper paths.Chain-state reconciliation
EventIngestionServicenow tracks last-known intent update times and logs stale intent conditions.Token registry persistence
TokensServiceso the app uses a repository-backed source of truth with an in-memory fallback when persistence is not enabled.Why
This closes the main gap between the documented on-chain slash behavior and the actual implementation, while also making the relevant services conform to the repo’s shared logging standard and adding a safety net for stale chain state.
Scope / Risk
closes Build the real, non-simulated
SolverRegistryService.slashSolver()submission path #261closes Build the chain-state reconciliation poll backstop #262
closes Replace ad hoc
console.log/console.errorwith the shared Winston logger in Soroban and sweeper services #263closes Back the Prisma
Tokenmodel with a real repository/service #264