Skip to content

Fix/quote write and accept signature #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james2177 merged 3 commits into from
Sep 2, 2026
Merged

Fix/quote write and accept signature #351

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d50d9c8
fix: validate quote() write matches target intent before persisting
martinzhames Aug 31, 2026
9398e49
fix: verify solver signature in IntentsController.accept()
martinzhames Aug 31, 2026
24b4c9b
Merge branch 'main' into fix/quote-write-and-accept-signature
james2177 Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/intents/intents.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { BatchLookupDto } from "./dto/batch-lookup.dto";
import { UserThrottlerGuard } from "./user-throttler.guard";
import {
verifyStellarSignature,
buildAcceptMessage,
buildCancelMessage,
buildFillMessage,
} from "../common/stellar-signature";
Expand Down Expand Up @@ -268,6 +269,9 @@ export class IntentsController {
throw new ForbiddenException("Solver has insufficient bond");
}

// Verify the solver controls the claimed address (mirrors fill()/cancel()).
verifyStellarSignature(dto.solver, buildAcceptMessage(id, dto.solver), dto.signature);

const updated = await this.intentsService.acceptIfOpen(id, dto.solver);
if (!updated) {
const current = await this.intentsService.get(id);
Expand Down Expand Up @@ -463,7 +467,7 @@ export class IntentsController {
})
.sort((a, b) => Number(BigInt(b.dstAmount) - BigInt(a.dstAmount)));

if (dto.intentId && quotes.length > 0) {
if (dto.intentId && targetIntent && quotes.length > 0) {
await this.intentsService.update(dto.intentId, { quotedDstAmount: quotes[0].dstAmount });
}

Expand Down