Add solver bond, nonce, open-intent, and fee-revenue views - #320
Open
Inkman007 wants to merge 1 commit into
Open
Add solver bond, nonce, open-intent, and fee-revenue views#320Inkman007 wants to merge 1 commit into
Inkman007 wants to merge 1 commit into
Conversation
…points Adds withdraw_excess_bond (withdraws max safe amount above min_bond), get_user_nonce (read a user's submit_intent nonce), list_open_intents (paginated Open/PartiallyFilled intent discovery), and get_total_fees_collected (cumulative protocol fee revenue counter). Closes stellar-vortex-protocol#258 Closes stellar-vortex-protocol#257 Closes stellar-vortex-protocol#249 Closes stellar-vortex-protocol#248
|
@Inkman007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withdraw_excess_bond(solver)— withdraws exactly the max amount safely withdrawable abovemin_bond, reusingwithdraw_bond's existing logic ([High] Add awithdraw_excess_bondconvenience entrypoint #258)get_user_nonce(user)— read-only view of a user'ssubmit_intentnonce ([High] Add a publicget_user_nonceview #257)list_open_intents(offset, limit)— paginated, bounded view of currentlyOpen/PartiallyFilledintent IDs, maintained via an enumerableOpenIntentListalongside the existingOpenIntentscounter ([High] Add a paginatedlist_open_intentsview #249)get_total_fees_collected()— cumulative protocol fee counter (TotalFeesCollected), incremented infill_intentby the exactfeevalue transferred toFeeRecipient([High] Add aTotalFeesCollectedrunning counter #248)README and
docs/solver-integration-guide.mdupdated to document the new entrypoints.Test plan
cargo fmt/clippy/testbefore pushing; please confirm CI is green before mergeAllowedDstTokenList) and the sixOpenIntentscounter mutation sites (submit_intent,accept_intent,fill_intentpartial-reopen,cancel_intent,expire_intent,slash_solver)Closes #258
Closes #257
Closes #249
Closes #248