Skip to content

Batch intent view, dust-tolerant fills, slash-cycle cap, reputation badge - #323

Open
knytcomics-ui wants to merge 1 commit into
stellar-vortex-protocol:mainfrom
knytcomics-ui:feature/241-247-250-242-assigned-issues
Open

Batch intent view, dust-tolerant fills, slash-cycle cap, reputation badge#323
knytcomics-ui wants to merge 1 commit into
stellar-vortex-protocol:mainfrom
knytcomics-ui:feature/241-247-250-242-assigned-issues

Conversation

@knytcomics-ui

Copy link
Copy Markdown

Summary

Four assigned issues bundled into one PR:

Closes #250
Closes #247
Closes #241
Closes #242

Validation performed

  • No Rust toolchain was available in this environment, so cargo fmt/clippy/test could not be run locally.
  • Pre-existing, unrelated to this change: intent_settlement/src/lib.rs on main already fails to compile — set_config/load_config reference DEFAULT_MIN_BOND, DEFAULT_FILL_WINDOW, DEFAULT_INTENT_EXPIRY, DEFAULT_PROTOCOL_FEE_BPS, MAX_PROTOCOL_FEE_BPS, MIN_FILL_WINDOW_SECS, MIN_INTENT_EXPIRY_SECS, MIN_BOND_FLOOR, MAX_BATCH_SIZE, and MAX_EXTENSION_DURATION, none of which are defined anywhere in the crate (introduced by the merged feat/protocol-fee-cap PR feat: add max protocol fee cap and admin audit trail #184). CI on main's latest commits shows this as a standing failure, predating this branch. This PR does not touch or fix those names — it follows the same (currently-broken) references for consistency, per new-field additions to ProtocolConfig/IntentRecord/Error/IntentState and the new reputation_badge crate (not part of CI's intent_settlement-scoped workflow, so unaffected by the above).
  • Reviewed the diff by hand against existing patterns in the file (CEI ordering, checked arithmetic, event-emission style, storage TTL bumps) since automated verification wasn't possible.
  • examples/risk_aware_solver_bot.py changes verified with python3 -m py_compile.

⚠️ Given the pre-existing broken build on main, please run cargo build/cargo test in CI or locally before merging to confirm this PR's additions are syntactically correct — I was unable to do so myself.

…tion badge

- Add get_intents_batch for bulk intent lookups, wired into the solver bot
  example (Closes stellar-vortex-protocol#250).
- Add ProtocolConfig.min_partial_fill and dust_tolerance_bps so fill_intent
  rejects dust-spam fills and treats near-complete fills as Filled
  (Closes stellar-vortex-protocol#247).
- Cap Open -> Accepted -> Slashed cycles via ProtocolConfig.max_slash_cycles;
  intents exceeding it move to a new terminal Abandoned state (Closes stellar-vortex-protocol#241).
- Add a design note and minimal reputation_badge prototype contract for a
  soulbound solver tier badge (Closes stellar-vortex-protocol#242).

Note: intent_settlement/src/lib.rs already fails to build on main (undefined
DEFAULT_MIN_BOND/MAX_PROTOCOL_FEE_BPS/etc. constants referenced by
set_config/load_config, pre-existing from PR stellar-vortex-protocol#184); CI on main is currently
red for the same reason. No Rust toolchain was available in this environment
to run cargo fmt/clippy/test locally.
@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@knytcomics-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant