feat: add comprehensive test suites for governance and indexer - #328
Open
morgonpeters-cyber wants to merge 4 commits into
Open
feat: add comprehensive test suites for governance and indexer#328morgonpeters-cyber wants to merge 4 commits into
morgonpeters-cyber wants to merge 4 commits into
Conversation
…r-vortex-protocol#220) Implements test suite for the propose_config/execute_config governance pattern, verifying that protocol parameter changes (min_bond, fill_window, intent_expiry, protocol_fee_bps) require a 48-hour timelock with: - advance-notice event emission - proposal validation at proposal time - rejection before timelock delay - successful execution after timelock - preservation of already-accepted intents' deadlines Closes stellar-vortex-protocol#220
…-vortex-protocol#228) Implements test suite for the propose_set_min_bond_multiplier/ execute_set_min_bond_multiplier governance pattern, verifying that per-token bond multiplier changes require a 48-hour timelock with: - proposal blocking before timelock delay - successful execution after timelock - upper bound enforcement on multiplier values - rejection of zero or negative multipliers - preservation of already-accepted intents' eligibility Closes stellar-vortex-protocol#228
…-vortex-protocol#217) Implements comprehensive test suite for the indexer upgrade from reference implementation to a production-ready service backing: - Cursor persistence and resumption from stored ledger sequence - Detection and handling of cursors outside RPC retention window - RPC resilience with retry/backoff on transient failures - Health status tracking and exposure via status endpoint - Event query interface supporting filtering by intent, solver, and type - Persistent snapshot storage (JSON and SQLite-like behavior) - Ledger reorg detection and state rollback - Full event pipeline integration test Covers propose → execute patterns with proper error handling and state management as required by the indexer service upgrade specification. Closes stellar-vortex-protocol#217
…ellar-vortex-protocol#219) Implements comprehensive test suite for the resource-cost documentation pipeline CI job that automatically tracks and validates resource costs using the benchmark harness from issue stellar-vortex-protocol#10: - Benchmark output parsing and resource cost extraction - Published cost loading from documentation markdown - Drift detection with configurable percentage thresholds - Reporting of costs exceeding acceptable drift limits - Markdown report formatting for CI output - Integration with GitHub Actions issue/PR tracking - Scheduled weekly benchmarking with push-trigger on contract changes - Documentation section preservation during updates Verifies CI job behavior: - Exits with error status when drift exceeds configured threshold - Exits successfully when measured costs stay within threshold - Generates tracking issues when significant drift is detected - Updates documentation with approved new resource costs Closes stellar-vortex-protocol#219
|
@morgonpeters-cyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements test suites for four high-priority governance and infrastructure issues:
set_configprotocol-parameter changes #220: Tests for timelockedpropose_config/execute_configpattern ensuring protocol parameter changes (min_bond, fill_window, intent_expiry, protocol_fee_bps) require 48-hour timelockpropose_set_min_bond_multiplier/execute_set_min_bond_multiplierpattern verifying per-token bond multiplier governancereference-indexer.js#217: Tests for Soroban-RPC-backed indexer service upgrade covering cursor persistence, reorg handling, resilience, and query interfacedocs/149#219: Tests for resource-cost documentation pipeline CI job verifying benchmark drift detection and automated documentation updatesTest Coverage
Issue #220 - Timelocked Config Changes
Issue #228 - Timelocked Bond Multiplier Changes
Issue #217 - Indexer Service
Issue #219 - Resource Cost Pipeline
Commits
258534a- test: add tests for timelocked config parameter changes (issue [High] Implement timelocked governance forset_configprotocol-parameter changes #220)fa82d54- test: add tests for timelocked bond-multiplier changes (issue [High] Add timelocked governance to per-token bond-multiplier changes #228)1692430- test: add tests for Soroban-RPC-backed indexer service (issue [High] Build a real Soroban-RPC-backed indexer service fromreference-indexer.js#217)0a1b059- test: add tests for resource-cost documentation pipeline CI (issue [High] Build the resource-cost documentation pipeline referenced bydocs/149#219)Closes #220
Closes #219
Closes #217
Closes #218