Skip to content

feat:fix: resolve issues #268, #269, #270, #271 - #356

Open
dominionvinson-maker wants to merge 1 commit into
stellar-vortex-protocol:mainfrom
dominionvinson-maker:fix/issues-268-269-270-271
Open

feat:fix: resolve issues #268, #269, #270, #271#356
dominionvinson-maker wants to merge 1 commit into
stellar-vortex-protocol:mainfrom
dominionvinson-maker:fix/issues-268-269-270-271

Conversation

@dominionvinson-maker

Copy link
Copy Markdown

#268 – ActivityFeed screen-reader announcement

  • Implement debounced live-region announcement logic (1500 ms)
  • Track previous item count via ref; skip initial snapshot
  • Coalesce rapid arrivals into a single '1 new fill' / 'N new fills' message
  • Add aria-live='polite' + aria-atomic='true' to the role='status' div
  • Export ActivityFeedView for Storybook/test consumption
  • Fix missing useTranslation import; remove duplicate ActivityFeed export
  • Add activityFeed.* i18n keys to en.ts and es.ts

#269 – error.tsx boundaries for all route segments

  • Add branded error.tsx to: / (root), /explore, /explore/[id], /solve, /solve/[address], /my-intents
  • Each boundary logs the error, surfaces a message, and offers a 'Try again' button (reset) plus a context-appropriate back link

#270 – loading.tsx Suspense boundaries for all route segments

  • Add loading.tsx to: / (home), /explore, /explore/[id], /solve, /solve/[address], /my-intents
  • Reuse Skeleton primitives (SkeletonBlock, SkeletonCard, SkeletonDetailCard, SkeletonText) to match each page's layout

#271 – Light theme with prefers-color-scheme support

  • Migrate all vx-* Tailwind color tokens to CSS variable references (var(--vx-ink), var(--vx-card), etc.) in tailwind.config.ts
  • Define dark-mode variables on :root (existing palette, now default)
  • Add @media (prefers-color-scheme: light) block with a full light palette: white/grey surfaces, adjusted sage/lavender for contrast, inverted text hierarchy
  • Drive body background + radial gradients via variables
  • Remove hardcoded bg-vx-ink text-vx-text from layout.tsx body
  • Sync i18n catalogs: add highPriceImpactWarning to en.ts, add swap.destination.* + swap.quote.staleWarning to es.ts

Summary

Closes #

Changes

Testing

  • npm run build passes
  • npx tsc --noEmit passes
  • npm test passes (or note any skipped/unrelated failures)

Checklist

…col#269, stellar-vortex-protocol#270, stellar-vortex-protocol#271

stellar-vortex-protocol#268 – ActivityFeed screen-reader announcement
- Implement debounced live-region announcement logic (1500 ms)
- Track previous item count via ref; skip initial snapshot
- Coalesce rapid arrivals into a single '1 new fill' / 'N new fills' message
- Add aria-live='polite' + aria-atomic='true' to the role='status' div
- Export ActivityFeedView for Storybook/test consumption
- Fix missing useTranslation import; remove duplicate ActivityFeed export
- Add activityFeed.* i18n keys to en.ts and es.ts

stellar-vortex-protocol#269 – error.tsx boundaries for all route segments
- Add branded error.tsx to: / (root), /explore, /explore/[id],
  /solve, /solve/[address], /my-intents
- Each boundary logs the error, surfaces a message, and offers
  a 'Try again' button (reset) plus a context-appropriate back link

stellar-vortex-protocol#270 – loading.tsx Suspense boundaries for all route segments
- Add loading.tsx to: / (home), /explore, /explore/[id],
  /solve, /solve/[address], /my-intents
- Reuse Skeleton primitives (SkeletonBlock, SkeletonCard,
  SkeletonDetailCard, SkeletonText) to match each page's layout

stellar-vortex-protocol#271 – Light theme with prefers-color-scheme support
- Migrate all vx-* Tailwind color tokens to CSS variable references
  (var(--vx-ink), var(--vx-card), etc.) in tailwind.config.ts
- Define dark-mode variables on :root (existing palette, now default)
- Add @media (prefers-color-scheme: light) block with a full
  light palette: white/grey surfaces, adjusted sage/lavender for
  contrast, inverted text hierarchy
- Drive body background + radial gradients via variables
- Remove hardcoded bg-vx-ink text-vx-text from layout.tsx body
- Sync i18n catalogs: add highPriceImpactWarning to en.ts,
  add swap.destination.* + swap.quote.staleWarning to es.ts
@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@dominionvinson-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant