feat:fix: resolve issues #268, #269, #270, #271 - #356
Open
dominionvinson-maker wants to merge 1 commit into
Open
feat:fix: resolve issues #268, #269, #270, #271#356dominionvinson-maker wants to merge 1 commit into
dominionvinson-maker wants to merge 1 commit into
Conversation
…col#269, stellar-vortex-protocol#270, stellar-vortex-protocol#271 stellar-vortex-protocol#268 – ActivityFeed screen-reader announcement - Implement debounced live-region announcement logic (1500 ms) - Track previous item count via ref; skip initial snapshot - Coalesce rapid arrivals into a single '1 new fill' / 'N new fills' message - Add aria-live='polite' + aria-atomic='true' to the role='status' div - Export ActivityFeedView for Storybook/test consumption - Fix missing useTranslation import; remove duplicate ActivityFeed export - Add activityFeed.* i18n keys to en.ts and es.ts stellar-vortex-protocol#269 – error.tsx boundaries for all route segments - Add branded error.tsx to: / (root), /explore, /explore/[id], /solve, /solve/[address], /my-intents - Each boundary logs the error, surfaces a message, and offers a 'Try again' button (reset) plus a context-appropriate back link stellar-vortex-protocol#270 – loading.tsx Suspense boundaries for all route segments - Add loading.tsx to: / (home), /explore, /explore/[id], /solve, /solve/[address], /my-intents - Reuse Skeleton primitives (SkeletonBlock, SkeletonCard, SkeletonDetailCard, SkeletonText) to match each page's layout stellar-vortex-protocol#271 – Light theme with prefers-color-scheme support - Migrate all vx-* Tailwind color tokens to CSS variable references (var(--vx-ink), var(--vx-card), etc.) in tailwind.config.ts - Define dark-mode variables on :root (existing palette, now default) - Add @media (prefers-color-scheme: light) block with a full light palette: white/grey surfaces, adjusted sage/lavender for contrast, inverted text hierarchy - Drive body background + radial gradients via variables - Remove hardcoded bg-vx-ink text-vx-text from layout.tsx body - Sync i18n catalogs: add highPriceImpactWarning to en.ts, add swap.destination.* + swap.quote.staleWarning to es.ts
|
@dominionvinson-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#268 – ActivityFeed screen-reader announcement
#269 – error.tsx boundaries for all route segments
#270 – loading.tsx Suspense boundaries for all route segments
#271 – Light theme with prefers-color-scheme support
Summary
Closes #
Changes
Testing
npm run buildpassesnpx tsc --noEmitpassesnpm testpasses (or note any skipped/unrelated failures)Checklist
feat:,fix:,chore:, etc.)closes Fix ActivityFeed's missing screen-reader status announcement #268
closes Add Next.js route-level error.tsx boundaries #269
closes Add Next.js route-level loading.tsx boundaries #270
closes Build a light theme with prefers-color-scheme support #271