feat: add QR code component and solver/swap UI enhancements - #362
Open
bumblebee-2020 wants to merge 1 commit into
Open
feat: add QR code component and solver/swap UI enhancements#362bumblebee-2020 wants to merge 1 commit into
bumblebee-2020 wants to merge 1 commit into
Conversation
- Add QrCode component (QrCode.tsx) with Storybook story and full test suite - Add qrCode utility lib with encoding/rendering logic (qrCode.ts) - Expand SolvePageClient with new solver detail and UX improvements - Enhance SwapCard with additional interaction and display improvements - ConnectWalletButton minor accessibility/UX fix - Fix broken syntax in explore/page.tsx and solve/page.tsx (orphaned merge artifacts) - Fix missing closing brace in solve/[address]/page.test.tsx - Minor layout tweaks to solve/page.tsx and explore/page.tsx - Add global CSS utility classes
|
@bumblebee-2020 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Closes #280
Closes #281
Closes #282
Closes #283
feat: QR code component, solver/swap UI enhancements, syntax fixes
Description:
Summary
Adds a reusable QR code component with its own utility library, expands the solver detail UI, and improves the swap card.
Also fixes a handful of broken syntax artifacts left over from earlier merges on this branch.
Changes
New
QrCode.tsx— reusable QR code component with accessible SVG outputqrCode.ts— pure encoding/rendering utility library for QR matrix generationQrCode.test.tsx— full unit test coverage for the componentQrCode.stories.tsx— Storybook story for visual testingUpdated
SolvePageClient.tsx— expanded solver detail section with UX improvementsSwapCard.tsx— additional interaction polish and display improvementsConnectWalletButton.tsx— minor accessibility/UX fixglobals.css— added utility classes used by new componentsFixes
explore/page.tsx— removed orphaned merge artifact (), ssr: false, });) and duplicate default exportsolve/page.tsx— removed orphaned merge artifact from earlier merge conflictsolve/[address]/page.test.tsx— added missing closing});for outerdescribeblockTesting
QrCode.test.tsx)tsc)