Implement tasks #218-221: Circuit breaker, contract validation, webho… - #364
Open
rasputin2525 wants to merge 1 commit into
Open
Implement tasks #218-221: Circuit breaker, contract validation, webho…#364rasputin2525 wants to merge 1 commit into
rasputin2525 wants to merge 1 commit into
Conversation
…tract validation, webhook config, and MCP tests - Task stellar-vortex-protocol#218: Added circuit breaker for RPC failures in indexer - Configurable MAX_CONSECUTIVE_ERRORS (default: 20) - Long sleep interval (5 min) after max errors reached - Prometheus gauge for consecutive errors - Reset on successful cycle - Task stellar-vortex-protocol#219: Contract ID validation in all services - Extracted validation to lumenqraph-core - Applied validation in API, webhooks, and MCP services - Added startup validation tests - Fail fast on invalid contract IDs - Task stellar-vortex-protocol#220: Webhook encryption key configuration - Read encryption key at startup, not per delivery - Added encryption_key field to Config - Fail fast if key missing at startup - Safety check against default test key in production - Task stellar-vortex-protocol#221: MCP server integration tests - Full JSON-RPC protocol testing - stdio round-trip tests - Error handling tests (malformed JSON, unknown methods) - Missing required field validation - Complete initialize -> tools/list -> tools/call flow
|
@rasputin2525 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements four critical improvements to the Lumenqraph system:
🛡️ Circuit Breaker for Indexer (#291)
Closes #291
MAX_CONSECUTIVE_ERRORS(default: 20) with fallback to 5-minute polling intervalslumenqraph_consecutive_errorsPrometheus gauge for monitoring✅ Contract ID Validation (#219)
**Closes #290
lumenqraph-corefor reusability🔐 Webhook Encryption Key Configuration (#220)
Closes #289
encryption_keyfield to webhook Config structWEBHOOK_ENCRYPTION_KEYis missing at startup🧪 MCP Server Integration Tests (#221)
Closes #288
Technical Details
thiserrorimplementationsTesting
All implementations include extensive test suites covering:
Ready for review and deployment! 🚀