Add Galexie to Makefile #885
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Makefile build process by adding Galexie dependency configuration that was previously missing. The Dockerfile already expected GALEXIE build arguments, but the Makefile wasn't providing them, causing local builds to fail while CI builds (which don't use the Makefile) continued to work correctly.
Changes:
- Added GALEXIE_REPO and GALEXIE_SHA variable extraction from image.json
- Added GALEXIE build arguments to the Docker build command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fnando
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add GALEXIE_REPO and GALEXIE_SHA variables to extract Galexie dependency info from image.json. Pass these as build arguments during Docker image build.
Why
Enable the quickstart image build process to include Galexie as a configurable dependency when building with the makefile. The makefile is currently broken because it doesn't provide the galexie details. The ci run that builds the image normally works as expected and is unaffected by the bug.