Remove ENABLE_RPC conditional check for config copy #886
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unnecessary conditional check when copying the stellar-rpc.conf supervisor configuration file, aligning it with the pattern used for other optional service configs.
Changes:
- Removed the
ENABLE_RPCenvironment variable check that gated copying stellar-rpc.conf during supervisor config setup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fnando
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Copy stellar-rpc.conf unconditionally during supervisor config setup, removing the ENABLE_RPC environment variable check.
Why
The RPC config file should always be copied alongside other optional configs like galexie.conf and friendbot.conf, which already copy unconditionally with silent failure fallback. It's unnecessary to gate it. I am guessing at some point we thought it was necessary but the service won't be started automatically.
This isn't causing any problems. I noticed the inconsistency when I was adding Galaxie here recently to the same area of code and went on a bit of search trying to figure out how we should be doing it then realising the gate for RPC is not required.