Please hardcoded packages with Kadence packages (npm)

[ravinderk]

KAD-5419

Blocker

• move packages/components change to kadence/components - KAD-5486 Block Settings - Border Color Picker isn't working properly. Closes on first input. #970 - https://github.com/stellarwp/kadence-components/releases/tag/1.1.8

Description

This pull request implement logic to use Kadence packages (npm), instead of hardcoded packages.

[github-actions]

🎉 Zip build complete

• 💾 Download zip
• 🛝 Test in WordPress Playground

[gilbert-hernandez]

@ravinderk

It looks like there are some conflicts that need to be resolved. I saw the same issue that Shayne found when I set a custom size for the margin and padding. I updated the kadence/components dependency in the package.json to use the "github:stellarwp/kadence-components#fix/KAD-5419-add-missing-style" branch. However, the problem still exists when I use that updated branch.

The ResponsiveMeasureRangeControl component is responsible for the padding/margin in the blocks, but I don't see that was an updated component in kadence/components repo (I'll comment there too).

Also, this is a strange Linting error. In the past, I've mostly ignored the linting errors, but I'm trying to make sure we don't have them going forward. This linting error may be because the dist/ directory for the helpers/components/icons repos don't exist when linting. We may need to update the workflow file or add a step after “Install dependencies” and before “Run linters” that builds the Kadence packages, for example:

      - name: Build Kadence workspace packages (for ESLint import/named)
        run: |
          for pkg in helpers icons components; do
            dir="node_modules/@kadence/${pkg}"
            if [ -f "$dir/package.json" ]; then
              (cd "$dir" && npm run build)
            fi
          done

[gilbert-hernandez]

is that extra supposed to be in the name?"link-kadence-packages"

[ravinderk]

fixed

[gilbert-hernandez]

Looks the branch needs to be updated when the components repo is merged.

[ravinderk]

fixed