Skip to content

Fix: Sticky header with shrink overlaps content at scrollY=0 #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Contributolo wants to merge 2 commits into
base: master
Choose a base branch
from
+18 −0
Open

Fix: Sticky header with shrink overlaps content at scrollY=0 #954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e1bbb
Fix: Sticky header with shrink overlaps content at scrollY=0
Contributolo Mar 16, 2026
0866a41
Refactor sticky header position logic
Contributolo Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/assets/js/kb-header-block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,24 @@ class KBHeader {
parent.classList.remove('child-is-fixed');
document.body.classList.remove('header-is-fixed');
}
// Fix stale placeholder height and position when back at top.
//
// Two timing issues cause the header to overlap page content at scrollY=0:
// 1. elHeight (line ~486) is measured before the shrink block (line ~571)
// restores the header row, so placeholderWrapper gets the shrunk value.
// 2. isSticking (used at line ~597) reflects the previous scroll frame,
// so position:fixed persists even though setStickyChanged(false) runs
// afterwards.
//
// Re-measuring and resetting here — after both shrink and class logic
// have completed — corrects both issues in a single pass.
if ( window.scrollY === 0 && this.shrinkMain && ( ! isTransparent || hasStickySection ) ) { this.stickyWrapper.style.position = 'initial';
this.stickyWrapper.style.width = 'initial';
this.stickyWrapper.style.left = 'initial';
this.stickyWrapper.style.top = 'initial';

this.placeholderWrapper.style.height = this.stickyWrapper.offsetHeight + 'px';
}
}

activeSizeCased(size) {
Expand Down