Merged
Conversation
Contributor
Author
6a25f72 to
e5fddb0
Compare
Contributor
Author
|
Sorry about all the updates, sitting in a train trying to find better names. |
This is a simple PHPUnit integration for php-quickcheck. It consists of a custom assertion and a static factory method. To use this in a PHPUnit test, call $this->assertThat(Gen::forAll($generators, $property), Prop::check(10));
Owner
|
This seems great, thank you very much! |
Contributor
Author
|
I'm good with the current shape. |
Contributor
Author
|
Well, I can add a blurb to the readme maybe. |
Contributor
Author
|
Now I think I'm okay with the PR, so if you are happy with it, too, it's ready to be merged. |
Contributor
Author
|
Since the README can't be the cause, maybe some changes you made while adding |
Owner
|
It's all good. Looks like there was some temporary error with composer install and the random shrink test sometimes doesn't generate a failing case. Thanks again for your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple PHPUnit integration for php-quickcheck.
It consists of a custom assertion and a static factory method.
To use this in a PHPUnit test, call
The output of a failing test looks like:
The smallest shrunk value is displayed using
var_exportso it can be copied and pasted into the propertyClosurefor easy debugging.Please consider the constraint class name and the factory method name as a suggestion - happy to rename them to something better.
Due to the method signatures of the overridden methods from
PHPUnit\Framework\Constraint\Constraint, the constraint class is only PHP 7 compatible.It would be possible to provide alternative implementations of the custom assertion for ancient PHPUnit versions that are compatible with PHP 5.6, but I doubt it is worth the effort.