Fixed checksum CRC issue for values less than 1000#25
Open
ghost wants to merge 1 commit into
Open
Conversation
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of CRC checksum errors occurring for QR codes with CRC less than 1000. Currently, the validation function compares '0028' (checksum) with '28' (hash), resulting in a 'Checksum validation failed.' error. This issue is tracked in Issue #3.
To fix this issue, I have updated the validation function to handle CRC checksums less than 1000 correctly, ensuring that the comparison between checksum and hash is done accurately.
Changes Made
Related Issues