merge develop into main#146
Merged
Merged
Conversation
Integrate migration tools into CI
Fix the Nix substituter URL and trusted keys, migrate to the current Darwin SDK package, add a lockfile, and wire up cache publishing CI. Also include Metal shader sources in the Nix source filter and make mlx-bench tests robust in source-only Nix builds.
Harden the migration tools workflow with least-privilege permissions, concurrency, and v5 GitHub actions. Make strangler diff failures explicit, parse Cargo.toml with toml, report walkdir errors, and add focused tests plus README/CONTRIBUTING docs.
…145) The `if: ${{ secrets.ANTHROPIC_API_KEY != '' }}` at job level was invalid — the `secrets` context isn't available in job-level `if:` expressions, only inside step `run:`/`uses:`/`with:` blocks. GitHub Actions therefore rejected the file on every push event, surfacing a 0-second "workflow file issue" failure even though the workflow is `workflow_dispatch` only. Fix: - Drop the job-level `if:`. - Add a first-step guard that exits 1 with a clear ::error:: message if ANTHROPIC_API_KEY is empty at runtime, so manual triggers without the secret configured fail loud at the gate instead of mid-evaluation. - Quote `$GITHUB_STEP_SUMMARY` in the report step (SC2086). Closes #143
1. Delete `test_validate_patch_async_timeout`. The previous form was a tautology — it asserted that `tokio::time::timeout(1ms, sleep(1s))` returns Err, which tests tokio itself, not validate_patch_async. The real timeout integration lives at the call site (line ~137) and tokio::time::timeout is upstream-tested. `test_validate_patch_async_invalid_header` still covers the function's own error path. 2. `Strangler::tracked_paths()` now bails on git failure instead of silently returning `Vec::new()`. Silent empty would classify as "no legacy hits" and let `--mode scan` report all-clear on a corrupted git state. Mirrors `diff_paths`'s existing behaviour. Adds `tracked_paths_reports_git_errors` regression test. 3. `.github/workflows/migration-tools.yml` job summary now wraps the OpenAPI and strangler JSON outputs in fenced code blocks. Without fences they render as unstyled inline text in the GitHub Actions UI. cargo build / clippy --all-targets -D warnings / test all green on migration-tools and mlx-bench. cargo fmt clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge develop into main