Add odin sequencer rpc#77
Open
josephnobes-stfc wants to merge 6 commits into
Open
Conversation
Installing projects with pyproject.toml can be completed using python poetry, utilising the native setuptools-scm. This succcessfully installs the odin-sequencer from the jupyter-rppc branch, currently without the rpc addition.
The rpc is an additional package also installed via pyproject.toml. This can be installed as an additional recipe pointing to the same repo. Currently this installs the module fine, but the dependencies specified in the pyproject seem to be ignored; pydantic and backports were ignored.
Issues with pydantic>2 support have been avoided by removing the requirement from odin-sequencer. This now installs using poetry (a must since setuptools3 in this version does not support pyproject.toml, and there is no setup.py in this project. The RPC recipe is included automatically with RRECOMMENDS, which can be overridden if desired.
Collaborator
Author
|
This recipe works for the currently pinned commit on the rpc branch: d99502143275715a76d9239632b68f692aaa7ce6. There are further changes anticipated that will require the combining of the two recipe files for odin-sequencer to just the single one again, and to a tagged release rather than a commit. This should actually be simpler, the dependencies of the RPC recipe will still need to be added. |
This will now build to the latest version working on the jupyter dev branch, now simply anticipating a change of tag to 0.3.0, and branch to main after the PR has been made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.