Add AD5259 driver and test script#20
Open
josephnobes-stfc wants to merge 5 commits into
Open
Conversation
Tested on hardware with expected responses, though resistances not physically measured
Oddly, using Mock() for smbus actually broke the test in the ad5272 file that was executed after this test. Changing the filename to make this test occur last also fixed this issue, so the ad5259 test was actually interfering with the other device's test file. Changing smbus to MagicMock() appears to sort the issue. It seems tests are not as segregated as I'd imagined.
Test also added to catch this
josephnobes-stfc
marked this pull request as ready for review
April 17, 2025 16:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on hardware with expected responses, though resistances not physically measured