Feature/with endpoint updates#111
Merged
Merged
Conversation
…dropdown. for volts vs millivolts, etc Fixed incorrect links in storybook intro page
…Dict object as their args, to allow key/value pairs this will allow us to inject the Param value if needed in the future
…kwarg pre method can return a modified value that gets used as the PUT request value Added tests to EndpointButton and EndpointInput to test this functionality
… range more intuitive. Added tests to Range Input Fixed broken test in EndpointInput
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Endpoint Range Input, an input with a dropdown for multiplying to a specified range (such as Voltage, with options for millivolts).
Added ability for pre/post methods to receive the param value as one of their arguments. This has required reworking the methods to accept a dict of kwargs, rather than a simple array. This is a breaking change for anyone using the pre/post methods.
Additionally, the pre_method can return a value that will be sent via PUT request. the assumption is that the method may want to alter the value before sending to the adapter, such as capitalising a string or changing a numerical value.
Closes #108
Closes #106