Conversation
💡 What: Replaced row-wise squared Euclidean norm calculations (`(X ** 2).sum(axis=1)` or `(X * X).sum(axis=1)`) with `np.einsum('ij,ij->i', X, X)`.
🎯 Why: Squaring then summing 2D arrays creates a large intermediate allocation in NumPy, making it slow in hot loops.
📊 Impact: Eliminating intermediate allocations leads to ~3-5x faster batch norm calculation, speeding up operations like k-means initialization, assignment, and vector addition.
🔬 Measurement: Check the runtime of `add_batch` and clustering. This optimizes the hot path used in `np.linalg.norm` and manual squared norms.
Co-authored-by: stffns <70039235+stffns@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughSquared-distance norm calculations across k-means, PQ, and IVFPQ now use ChangesDistance calculations
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pin numpy to <2.5.0 in the CI workflow to resolve the mypy type inference error 'Type statement is only supported in Python 3.12 and greater' triggered by newer numpy releases with the python_version='3.10' setting. Co-authored-by: stffns <70039235+stffns@users.noreply.github.com>
💡 What: Replaced row-wise squared Euclidean norm calculations (
(X ** 2).sum(axis=1)or(X * X).sum(axis=1)) withnp.einsum('ij,ij->i', X, X).🎯 Why: Squaring then summing 2D arrays creates a large intermediate allocation in NumPy, making it slow in hot loops.
📊 Impact: Eliminating intermediate allocations leads to ~3-5x faster batch norm calculation, speeding up operations like k-means initialization, assignment, and vector addition.
🔬 Measurement: Check the runtime of
add_batchand clustering. This optimizes the hot path used innp.linalg.normand manual squared norms.PR created automatically by Jules for task 8875688363573190367 started by @stffns
Summary by CodeRabbit
Performance
Reliability