Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bench: refresh competitive table from single fresh-process run #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
bench: refresh competitive table from single fresh-process run #55
Changes from all commits
c01233b1244043File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The benchmark table has been updated with fresh numbers, but the descriptive text in the following sections (### Reading the table, ### Positioning in plain language, and ### Caveats) still contains hardcoded values from the previous run.
For example:
(336 vs 475 us)should be(325 vs 483 us).355 usshould be359 us.819 usshould be994 us.13 msshould be13.9 ms.(16 s vs 112 s)should be(17 s vs 110 s).These should be updated to maintain consistency with the new table data.
Uh oh!
There was an error while loading. Please reload this page.