fix(release): install hypothesis in cibuildwheel test env - #57
Merged
Merged
Conversation
The v0.10.0 tag build failed on every wheel-test step with ModuleNotFoundError: hypothesis. Cause: PR #50 added tests/test_properties.py, which imports hypothesis, but CIBW_TEST_REQUIRES still only installed pytest. Add hypothesis so the wheel smoke test can collect every test file. No wheels were published from v0.10.0; this fix goes in before the retag so the next release attempt publishes cleanly.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Fixes the release workflow’s wheel test environment so cibuildwheel installs hypothesis, matching the project’s dev/test requirements and preventing tag builds from failing during pytest.
Changes:
- Update
CIBW_TEST_REQUIRESin the release workflow to includehypothesis>=6.100. - Align wheel-test dependencies with
pyproject.toml’s[project.optional-dependencies].dev.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.10.0 tag build failed on every wheel-test step:
```
E ModuleNotFoundError: No module named 'hypothesis'
```
Cause: PR #50 added `tests/test_properties.py`, which imports
`hypothesis`, but `release.yml` still only installs `pytest` in
the cibuildwheel test env.
Four wheel jobs (ubuntu, ubuntu-arm, macos-14, windows) all fail at
the inner `pytest {project}/tests -q` step. The `publish` job is
gated on `needs: [build_wheels, build_sdist]`, so nothing was
published to PyPI.
Fix
```yaml
CIBW_TEST_REQUIRES: "pytest hypothesis>=6.100"
```
Mirrors `pyproject.toml`'s `[dev]` pin.
Recovery path
Once this PR merges:
published, so the retag is clean):
```bash
git tag -d v0.10.0
git push origin :refs/tags/v0.10.0
```
```bash
git tag -a v0.10.0 -m "snapvec 0.10.0"
git push origin v0.10.0
```
Both steps require Jay's explicit OK since they touch shared tag state.
Test plan