chore(web): update chromiumoxide 0.5.7 -> 0.9.1 - #202
Merged
Merged
Conversation
The `tokio-runtime` feature is gone (tokio is the only runtime now, async-std support was removed in 0.9), otherwise the API we use is unchanged: the workspace builds, clippy is clean and all 20 `web` tests, including the live headless-Chrome ones, pass. Also drops the transitive async-std/tungstenite 0.20/winreg deps and brings async-tungstenite 0.32 and which 8. The CDP parse noise from recent Chromes is not gone with the bumped protocol, but it moved from ERROR to DEBUG (`chromiumoxide::conn`) plus one WARN per event (`chromiumoxide::handler`); the only offender seen with Chrome 152 is `Network.requestWillBeSentExtraInfo`. Comment updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chromiumoxideincrates/webfrom 0.5.7 to 0.9.1 (the sibling pal PR does the same forpal_music; pal consumes this crate via the[patch]section, so the two go together).tokio-runtimefeature no longer exists (0.9 dropped async-std; tokio is the only runtime), so the dependency line becomes plainchromiumoxide = "0.9". No source changes were needed beyond a comment.What changed upstream (0.6 → 0.9)
CdpEvent::Otherinstead of failing), CDP bumped to Chromium 142, option to disable automation detection.Page::add_init_script,click_with, browser process no longer inherits stdout.CDP parse noise
The "data did not match any variant of untagged enum Message" noise from recent Chromes is not gone with the newer protocol, but it is no longer ERROR level: chromiumoxide 0.9 logs it as DEBUG on
chromiumoxide::connplus one WARN per event onchromiumoxide::handler. Checked live with Chrome 152.0.7977.83: the only failing event wasNetwork.requestWillBeSentExtraInfo(6 frames for two page loads). The comment inbrowser.rsnow says so.Verification
cargo build(workspace),cargo clippy --all-targets -p web: cleancargo test -p web: 20 passed, including the live headless-Chrome tests (navigation, typing, cookies across launches, headless swap)