Skip to content

v1.2.2 - #62

Merged
jhollway merged 5 commits into
mainfrom
develop
Aug 28, 2026
Merged

v1.2.2#62
jhollway merged 5 commits into
mainfrom
develop

Conversation

@jhollway

Copy link
Copy Markdown
Member

Graphing

  • Improved how node_color= colours numeric node variables

Tests

  • Fixed the arc strength test depending on the BLAS

Copilot AI lite review requested due to automatic review settings August 28, 2026 13:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the autograph package for the v1.2.2 release by improving how numeric node_color attributes are rendered (continuous gradients vs categorical palettes) across graphr() and grapht(), and by stabilizing arc-strength testing across BLAS implementations.

Changes:

  • Treat numeric node attributes with >2 unique values as continuous and render them with a shared gradient scale (including a colourbar titled by the attribute).
  • Adjust guide/legend handling so continuous fill scales keep a colourbar rather than being coerced into discrete legend keys.
  • Update/extend tests to cover numeric gradients and make arc-strength tests BLAS-independent; bump version and release notes/docs.

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/testthat/test-grapht.R Adds a regression test ensuring grapht() uses a continuous fill scale for numeric node_color.
tests/testthat/test-graphr.R Adds tests for continuous gradient behavior, colourbar title, shared ranges across graphs(), and BLAS-stable arc-strength behavior.
R/grapht.R Detects continuous node color across waves and applies a gradient scale + colourbar for numeric mappings.
R/graphr.R Documents categorical vs continuous (measure) behavior for node_color.
R/graph_nodes.R Applies scale_fill_gradientn() with shared limits when node color is continuous numeric.
R/graph_legends.R Preserves colourbar guides for continuous fill scales; avoids forcing discrete legend keys.
R/graph_aes.R Adds .is_continuous() and routes numeric measures to continuous mapping; adds shared numeric range support.
NEWS.md Adds release notes for 1.2.2.
man/plot_grapht.Rd Updates rendered docs to describe categorical vs gradient node coloring.
man/plot_graphr.Rd Updates rendered docs to describe categorical vs gradient node coloring.
DESCRIPTION Bumps package version to 1.2.2.
cran-comments.md Updates test environment list for the submission.
Files not reviewed (2)
  • man/plot_graphr.Rd: Generated file
  • man/plot_grapht.Rd: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cran-comments.md Outdated
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.47%. Comparing base (56001e7) to head (f50f66b).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
R/graph_legends.R 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   90.42%   90.47%   +0.04%     
==========================================
  Files          37       37              
  Lines        4542     4576      +34     
==========================================
+ Hits         4107     4140      +33     
- Misses        435      436       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jhollway and others added 2 commits August 28, 2026 16:20
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jhollway
jhollway merged commit 9664fef into main Aug 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants