Skip to content

v2.3.1 - #167

Merged
jhollway merged 2 commits into
mainfrom
develop
Aug 26, 2026
Merged

v2.3.1#167
jhollway merged 2 commits into
mainfrom
develop

Conversation

@jhollway

Copy link
Copy Markdown
Member

Marking

  • Fixed is_longitudinal() marking a network whose ties carry no moments

Measures

  • Fixed tie_attribute.stocnet) and node_attribute.stocnet())
    • Returns every attribute where no attribute is named, as .igraph method already did
    • Reports tie attributes without 'from' and 'to', which identify a tie rather than describe it

Manipulating

  • Fixed a mark inside filter_ties() or mutate_ties() reading correct {tidygraph} context

Copilot AI lite review requested due to automatic review settings August 26, 2026 13:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the manynet 2.3.1 release by fixing three behavior regressions across marking, attribute extraction, and tidygraph-context handling, and by adding regression tests and release metadata updates.

Changes:

  • Fix is_longitudinal() to avoid marking networks as panels when time is recorded only via nodal changes (no time-bearing tie attributes).
  • Update tie_attribute() / node_attribute() methods for stocnet and network to return all attributes when attr_name is omitted (and drop from/to for stocnet tie attributes).
  • Prefer {tidygraph}’s active graph context over the stored context in active_network() to make nested verbs (e.g., marks inside filter_ties()) resolve against the correct network.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/testthat/test-mark_is.R Adds regression coverage for is_longitudinal() when ties carry no moments.
tests/testthat/test-manip_grab.R Adds tests for missing-attr_name attribute extraction and tidygraph-context precedence in nested calls.
R/reexports_classes.R Changes active_network() to read tidygraph context first, fixing nested context resolution.
R/measure_attributes.R Implements missing-attr_name behavior for stocnet/network and introduces .all_attributes() helper.
R/mark_changes.R Tightens is_longitudinal.igraph() to require time-bearing tie attributes for panel marking.
NEWS.md Adds 2.3.1 release notes.
DESCRIPTION Bumps package version to 2.3.1.
cran-comments.md Updates CRAN submission notes and reverse-dependency context for the release.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread NEWS.md Outdated
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (8933caa) to head (8b9c223).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/measure_attributes.R 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   83.08%   83.06%   -0.03%     
==========================================
  Files          42       42              
  Lines        6709     6718       +9     
==========================================
+ Hits         5574     5580       +6     
- Misses       1135     1138       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@jhollway
jhollway merged commit 3e289f0 into main Aug 26, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants