Conversation
…that were bugs in `manynet`
There was a problem hiding this comment.
Pull request overview
This PR prepares the manynet 2.3.1 release by fixing three behavior regressions across marking, attribute extraction, and tidygraph-context handling, and by adding regression tests and release metadata updates.
Changes:
- Fix
is_longitudinal()to avoid marking networks as panels when time is recorded only via nodal changes (no time-bearing tie attributes). - Update
tie_attribute()/node_attribute()methods forstocnetandnetworkto return all attributes whenattr_nameis omitted (and dropfrom/toforstocnettie attributes). - Prefer
{tidygraph}’s active graph context over the stored context inactive_network()to make nested verbs (e.g., marks insidefilter_ties()) resolve against the correct network.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-mark_is.R | Adds regression coverage for is_longitudinal() when ties carry no moments. |
| tests/testthat/test-manip_grab.R | Adds tests for missing-attr_name attribute extraction and tidygraph-context precedence in nested calls. |
| R/reexports_classes.R | Changes active_network() to read tidygraph context first, fixing nested context resolution. |
| R/measure_attributes.R | Implements missing-attr_name behavior for stocnet/network and introduces .all_attributes() helper. |
| R/mark_changes.R | Tightens is_longitudinal.igraph() to require time-bearing tie attributes for panel marking. |
| NEWS.md | Adds 2.3.1 release notes. |
| DESCRIPTION | Bumps package version to 2.3.1. |
| cran-comments.md | Updates CRAN submission notes and reverse-dependency context for the release. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 83.08% 83.06% -0.03%
==========================================
Files 42 42
Lines 6709 6718 +9
==========================================
+ Hits 5574 5580 +6
- Misses 1135 1138 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Marking
is_longitudinal()marking a network whose ties carry no momentsMeasures
tie_attribute.stocnet)andnode_attribute.stocnet()).igraphmethod already didManipulating
filter_ties()ormutate_ties()reading correct{tidygraph}context