Skip to content

v2.3.4 - #178

Merged
jhollway merged 7 commits into
mainfrom
develop
Sep 7, 2026
Merged

v2.3.4#178
jhollway merged 7 commits into
mainfrom
develop

Conversation

@jhollway

@jhollway jhollway commented Sep 7, 2026

Copy link
Copy Markdown
Member

Making

  • Fixed a couple of generate_islands() errors
    • Fixed to grow bridges as choose(islands, 2) and not as islands
    • Fixed deriving p from a two-mode network with a one-mode dyad count
  • Added two-mode support to the last three generate_*() functions (closes Add generate_fire(c(2,2)) and generate_citations(c(2,2))? #150)
    • generate_fire() burns along two-paths, closing four-cycles instead of triangles
    • generate_islands() builds a bipartite blockmodel with a planted diagonal
    • generate_citations() keeps its recency mechanism, but the target crosses the mode divide,
      and both modes grow so that the concentration turns over

Manipulating

  • Fixed bind_changes.igraph() replacing the changelog instead of appending
  • Added remaining row-wise verbs for the globals component (closes Do we need add_changes, join_changes, or filter_globals? #149)
    • Added bind_globals()
    • Added filter_globals()
    • Added arrange_globals()
    • Added delete_globals()
    • Added mutate_globals() to alter table columns
  • Improved to_time() to scope globals as it already scoped ties, changes, and missings

Modifying

Marking

  • Fixed is_signed() to check for a 'sign' column or a negative 'weight' column

Copilot AI lite review requested due to automatic review settings September 7, 2026 12:46
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.42857% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.98%. Comparing base (228e116) to head (cf5de22).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
R/manip_globals.R 71.87% 9 Missing ⚠️
R/make_generate.R 97.53% 2 Missing ⚠️
R/modif_scope.R 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   83.43%   83.98%   +0.55%     
==========================================
  Files          42       42              
  Lines        6796     6918     +122     
==========================================
+ Hits         5670     5810     +140     
+ Misses       1126     1108      -18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

generate_islands()’s p inference for two-mode inputs still subtracts a one-mode-style bridge-tie count, which can significantly mis-estimate p for islands >= 4.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR prepares the manynet 2.3.4 release by extending stochastic generators to support two-mode networks, introducing a to_positive() helper for signed networks, and tightening signed-network detection for edgelists.

Changes:

  • Added two-mode implementations for generate_fire(), generate_islands(), and generate_citations(), with updated documentation and tests.
  • Added to_positive() as an exported guard that keeps only positive ties for signed networks, plus tests and documentation.
  • Fixed is_signed.data.frame() to detect signedness via a sign column or negative weight values (instead of relying on column position).
File summaries
File Description
tests/testthat/test-manip_format.R Adds tests for to_positive(), to_unsigned() exclusion recording, and is_signed.data.frame() behavior.
tests/testthat/test-make_generate.R Adds tests asserting two-mode support and expected properties for generate_fire/islands/citations().
tests/testthat/test-functional_to.R Adds to_positive to functional invariants.
R/modif_weight.R Implements to_positive() and adjusts where exclusion info is recorded for to_unsigned().
R/mark_format.R Updates is_signed.data.frame() to use sign/weight columns explicitly.
R/make_generate.R Implements two-mode helpers and enables two-mode paths for the last three generate_*() functions.
NEWS.md Adds 2.3.4 release notes aligned with the PR description.
NAMESPACE Exports to_positive.
man/modif_weight.Rd Documents to_positive and updates the modif_weight manual page.
man/make_stochastic.Rd Documents new two-mode semantics and examples for the stochastic generators.
DESCRIPTION Bumps package version to 2.3.4.
Review details

Files not reviewed (2)

  • man/make_stochastic.Rd: Generated file
  • man/modif_weight.Rd: Generated file
  • Files reviewed: 9/11 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread R/make_generate.R
@jhollway jhollway self-assigned this Sep 7, 2026
@jhollway
jhollway merged commit f96b15e into main Sep 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants