Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 60.51% 61.22% +0.71%
==========================================
Files 9 9
Lines 704 717 +13
==========================================
+ Hits 426 439 +13
Misses 278 278 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR releases migraph 1.6.8 and focuses on significantly speeding up net_regression() permutations to address CRAN NOTE runtime concerns around the predict() examples, while keeping statistical results unchanged for a given seed.
Changes:
- Optimized
net_regression()permutation path by permuting matrices directly (with a fallback tomanynet::to_permuted()once a matrix method exists). - Reworked
vectorise_list()to use base matrix assembly instead ofdplyr::bind_cols(), reducing per-permutation overhead. - Added tests to lock in permutation equivalence and delegation behavior; updated docs/examples and versioning (DESCRIPTION/NEWS).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
R/model_regression.R |
Switches permutation implementation to a fast matrix-based path; rewrites vectorisation to avoid tibble/data-frame overhead. |
tests/testthat/test-model_regression.R |
Adds regression tests ensuring the new permutation shortcut matches manynet::to_permuted() and that delegation logic behaves as intended. |
R/model_predict.R |
Updates examples with guidance about using larger times for publication-ready results. |
man/predict.Rd |
Keeps rendered documentation examples aligned with the updated roxygen examples. |
NAMESPACE |
Removes now-unused dplyr::bind_cols import. |
DESCRIPTION |
Bumps package version to 1.6.8. |
NEWS.md |
Adds 1.6.8 release notes describing the performance improvements and invariance claims. |
Files not reviewed (1)
- man/predict.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Models
net_regression()(by about 35x), resolving the CRAN NOTE about the running time of thepredict()examplesmanynet::to_permuted()again once manynet gains a method for matrix inputChecklist: