Demo site: reuse dot.png as a 10-image gallery - #85
Merged
Conversation
…ually thin Every snapshot captured by the e2e suite -- 10 of them, after the last PR -- was the same near-identical page: an h1, a paragraph, the .box regression target, and exactly one small <img>. Fine for automated assertions, but thin to actually look at when browsing a populated instance manually, which is the whole point of the Docker+Playwright verification pattern this repo leans on. Adds a .thumbs gallery of 10 <img> tags (reusing the existing dot.png asset with distinct alt="dot-N" per tag -- no new binary assets needed) below the .box element. Purely additive to the page; doesn't touch the .box regression trick or anything any test asserts on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NrQeh9CXrigN1cvpJuyzy4
…flict Three PRs landed on main after this branch forked (#86 self-hosting, #87 mask popup, #88 six more e2e stories), two of which touched the same examples/demo-app/CODEMAP.md paragraph this branch also edited. index.html and style.css merged cleanly with no conflict; CODEMAP.md's prose needed manual reconciliation -- kept main's up-to-date "fourteen tests" description and spliced this branch's .thumbs gallery sentence back into the site/ bullet it belongs to. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NrQeh9CXrigN1cvpJuyzy4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every snapshot captured by the e2e suite was the same near-identical page
-- an h1, a paragraph, the
.boxregression target, and exactly one small<img>. Fine for automated assertions, thin to actually look at whenbrowsing a populated instance manually.
Adds a
.thumbsgallery of 10<img>tags (reusing the existingdot.pngasset with distinct
alt="dot-N"per tag -- no new binary assets) below the.boxelement. Purely additive; doesn't touch the.boxregression trickor anything any test asserts on.
Test plan
npm run lint --workspacescleannpm test --workspaces-- 3 client + 55 viewer, unaffectednpm run test:e2e -w examples/demo-app-- 6/6 (this branch is offmain, before PR Grow e2e suite to 10 captured snapshots #84's 10-capture growth merges; no conflict, justindependent)
ruff check+pytest-- 141/141examples/demo-app/CODEMAP.mdupdatedCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01NrQeh9CXrigN1cvpJuyzy4